This is an archive of the discontinued LLVM Phabricator instance.

Do not link clang_rt.cfi on Android.
ClosedPublic

Authored by eugenis on Oct 13 2017, 4:19 PM.

Details

Summary

The OS provides cross-dso CFI support starting with Android O.
Trapping mode does not require any runtime at all, and diagnostic mode
requires just ubsan-standalone.

Diff Detail

Repository
rL LLVM

Event Timeline

eugenis created this revision.Oct 13 2017, 4:19 PM
pcc added inline comments.Oct 13 2017, 5:40 PM
clang/test/Driver/sanitizer-ld.c
605 ↗(On Diff #118986)

Why was this passing before?

eugenis added inline comments.Oct 13 2017, 5:44 PM
clang/test/Driver/sanitizer-ld.c
605 ↗(On Diff #118986)

because android has NeedsSharedRt, and clang driver never adds clang_rt.cfi as a shared library.

pcc accepted this revision.Oct 13 2017, 5:58 PM

LGTM

This revision is now accepted and ready to land.Oct 13 2017, 5:58 PM
This revision was automatically updated to reflect the committed changes.