This is an archive of the discontinued LLVM Phabricator instance.

[CUDA] Require libdevice only if needed
ClosedPublic

Authored by Hahnfeld on Oct 13 2017, 12:57 PM.

Details

Summary

If the user passes -nocudalib, we can live without it being present.
Simplify the code by just checking whether LibDeviceMap is empty.

Diff Detail

Event Timeline

Hahnfeld created this revision.Oct 13 2017, 12:57 PM
tra edited edge metadata.Oct 13 2017, 1:01 PM

The change could use a test.

Hahnfeld updated this revision to Diff 118969.Oct 13 2017, 1:33 PM

Fix one more condition that checks for nvvm/libdevice and add a test.

tra accepted this revision.Oct 13 2017, 1:37 PM

Looks good. Thank you.

This revision is now accepted and ready to land.Oct 13 2017, 1:37 PM
This revision was automatically updated to reflect the committed changes.