Page MenuHomePhabricator

[Hexagon] New HVX target features.
ClosedPublic

Authored by sgundapa on Oct 12 2017, 9:25 AM.

Details

Summary

This patch lets the llvm tools handle the new HVX target features that
are added by frontend (clang). The target-features are of the form
"hvx-length64b" for 64 Byte HVX mode, "hvx-length128b" for 128 Byte mode HVX.
"hvx-double" is an alias to "hvx-length128b" and is soon will be deprecated.
The hvx version target feature is upgated form "+hvx" to "+hvxv{version_number}.
Eg: "+hvxv62"

For the correct HVX code generation, the user must use the following
target features.
For 64B mode: "+hvxv62" "+hvx-length64b"
For 128B mode: "+hvxv62" "+hvx-length128b"

Clang picks a default length if none is specified. If for some reason,
no hvx-length is specified to llvm, the compilation will bail out.
There is a corresponding clang patch.

Diff Detail

Repository
rL LLVM

Event Timeline

sgundapa created this revision.Oct 12 2017, 9:25 AM
kparzysz accepted this revision.Oct 12 2017, 9:55 AM

LGTM with a comment.

test/tools/llvm-objdump/Hexagon/source-interleave-hexagon.ll
37 ↗(On Diff #118801)

Could you replace all occurrences of -hvx-length128b with +hvx-length64b?

This revision is now accepted and ready to land.Oct 12 2017, 9:55 AM
This revision was automatically updated to reflect the committed changes.