This is an archive of the discontinued LLVM Phabricator instance.

Add a cmake option for using strcmp for type_infos.
AbandonedPublic

Authored by danalbert on Oct 11 2017, 3:39 PM.

Details

Summary

libc++ doesn't yet have the code for this, but libc++abi does. Adding
the switch to libc++ since the flag in libc++abi is
_LIBCXX_DYNAMIC_FALLBACK, not _LIBCXXABI_DYNAMIC_FALLBACK, and it
will be needed here as well.

Event Timeline

danalbert created this revision.Oct 11 2017, 3:39 PM
danalbert planned changes to this revision.Oct 11 2017, 3:42 PM

Actually, I was wrong. This is implemented. Will update to set the flag the configures this and add a test.

danalbert abandoned this revision.Oct 11 2017, 4:21 PM

zygoloid and nbjoerg got me pointed in the right direction on this. Looks like the user didn't have a key function defined for one of their classes, which was actually the root of the problem.