This is an archive of the discontinued LLVM Phabricator instance.

[X86] Add CLWB intrinsic. clang part
ClosedPublic

Authored by craig.topper on Oct 10 2017, 9:43 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

craig.topper created this revision.Oct 10 2017, 9:43 PM
craig.topper retitled this revision from [X86] Add CLWB intrinsic. to [X86] Add CLWB intrinsic. clang part.Oct 10 2017, 9:44 PM
craig.topper added reviewers: RKSimon, zvi, igorb.
craig.topper edited subscribers, added: cfe-commits; removed: mgorny.
RKSimon added inline comments.Oct 12 2017, 9:01 AM
lib/Headers/clwbintrin.h
34 ↗(On Diff #118538)

Worth adding the doxygen description? You can probably just copy+paste+modify the _mm_clflush documentation.

test/CodeGen/builtin-clwb.c
4 ↗(On Diff #118538)

Match what is done in the other files: use -ffreestanding instead of defining __MM_MALLOC_H and include the "top header":<x86intrin.h>

Address review feedback

RKSimon accepted this revision.Oct 12 2017, 11:41 AM

LGTM - one minor

lib/Headers/clwbintrin.h
42 ↗(On Diff #118816)

\param __m

This revision is now accepted and ready to land.Oct 12 2017, 11:41 AM
This revision was automatically updated to reflect the committed changes.