Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
clang/lib/CodeGen/CGBuiltin.cpp | ||
---|---|---|
9726 ↗ | (On Diff #118408) | weird indentation? |
9733 ↗ | (On Diff #118408) | Urg, this isn't a bool? Do we want it to be? |
9761 ↗ | (On Diff #118408) | Accidentally left over? |
9762 ↗ | (On Diff #118408) | s/8/NumElements/? Maybe it would be better to write it as "Return value has type [[f16 x 2] x NumResults]."? |
9784 ↗ | (On Diff #118408) | Nit, at this point it's probably better to assign NumResults in each branch, since there are only two. clang should make sure that we don't accidentally use it uninitialized. |
9786 ↗ | (On Diff #118408) | s/are using/use/ |
9800 ↗ | (On Diff #118408) | spacing. (Probably just worth clang-formatting this and the other patch.) |
9802 ↗ | (On Diff #118408) | Nit, we know that there won't ever be more than 8 elements... |
Addressed Justin's comments.
clang/lib/CodeGen/CGBuiltin.cpp | ||
---|---|---|
9726 ↗ | (On Diff #118408) | My emacs and clang-format keep fighting case indentation... Fixed. |
9733 ↗ | (On Diff #118408) | There are no explicit declarations for these builtins in CUDA headers. Callers of these builtins pass 0/1 and corresponding intrinsic described in NVVM-IR spec shows the argument type as i32, so I've made the type integer in clang. |
9762 ↗ | (On Diff #118408) | That was part of the leftover block. Particular types are irrelevant here. All we care is to store whatever intrinsic call returned ([4 or 8 elements of v2f16 or float] ) in the destination array (which is int[] ). |
9802 ↗ | (On Diff #118408) | We have two extra arguments -- destination buffer and stride. |
clang/lib/CodeGen/CGBuiltin.cpp | ||
---|---|---|
9733 ↗ | (On Diff #118408) | sgtm |