This is an archive of the discontinued LLVM Phabricator instance.

[llvm-rc] Handle the /I option
ClosedPublic

Authored by zturner on Oct 10 2017, 9:08 AM.

Details

Summary

This is not only the directory that include files are searched for, which could be handled by a C/C++ preprocessor, but also controls where resource files are searched for. For example, if you specify /I foo and then have a statement like mybmp BITMAP foo.bmp, then foo.bmp is searched for in the directory foo. A C preprocessor can't handle this, so we still need logic for it. The rules implemented in this patch conform to the algorithm described in MSDN for how rc searches for resources.

Diff Detail

Event Timeline

zturner created this revision.Oct 10 2017, 9:08 AM
rnk accepted this revision.Oct 10 2017, 6:23 PM

lgtm

llvm/tools/llvm-rc/ResourceFileWriter.cpp
1439

Maybe add a similar comment?

// 4. Last, search INCLUDE paths from the environment.
This revision is now accepted and ready to land.Oct 10 2017, 6:23 PM
This revision was automatically updated to reflect the committed changes.