This is an archive of the discontinued LLVM Phabricator instance.

[Sema][Crash] Correctly handle an non-dependent noexcept expr in function template
ClosedPublic

Authored by erichkeane on Oct 9 2017, 11:39 AM.

Details

Summary

It seems that all of the other templated cases are handled correctly,
however the function template case was not correctly handled. This
patch recovers from this condition by setting the function to noexcept
after diagnosing. Previously it simply set NoexceptExpr to null,
which caused an Assert when this was evaluated during substitution.

Diff Detail

Event Timeline

erichkeane created this revision.Oct 9 2017, 11:39 AM

Bump! I realize the two of you are super busy, but if anyone else on cfe-commits wants to take a look, I'd apprecate it!
-Erich

rnk accepted this revision.Oct 12 2017, 3:04 PM

Looks good, thanks!

This revision is now accepted and ready to land.Oct 12 2017, 3:04 PM
This revision was automatically updated to reflect the committed changes.