Use error() instead of warn() to report undefined symbols.
ClosedPublic

Authored by ruiu on Fri, Oct 6, 4:11 PM.

Details

Summary

I believe the reason why we used warn() instead of error() to report
undefined symbols is because the older implementation of error() exitted
immediately. Here, we want to find as many undefined symbols as we can,
so I chose to use warn() instead of error().

Now error() does not exit immediately, so it doesn't make sense to keep
them as warnings.

Diff Detail

Repository
rL LLVM
ruiu created this revision.Fri, Oct 6, 4:11 PM
smeenai added a subscriber: smeenai.Fri, Oct 6, 4:17 PM

I'd been meaning to complain about lld-link outputting "warning" instead of "error" for undefined symbols. Thanks for fixing :)

This revision is now accepted and ready to land.Fri, Oct 6, 4:28 PM
This revision was automatically updated to reflect the committed changes.