This is an archive of the discontinued LLVM Phabricator instance.

[libFuzzer] Disable experimental clang coverage support by default.
ClosedPublic

Authored by Dor1s on Oct 5 2017, 2:55 PM.

Details

Summary

It can be enabled via "-use_clang_coverage=1" flag. Reason for disabling:
libFuzzer resets Clang Counters and makes it impossible to generate coverage
report for a regular fuzz target (i.e. not standalone build).

Event Timeline

Dor1s created this revision.Oct 5 2017, 2:55 PM
Dor1s added a comment.Oct 5 2017, 2:57 PM

Surprisingly, none of the tests has failed. Now I feel that I did something wrong, since you said that I should update one test :)

kcc accepted this revision.Oct 5 2017, 3:03 PM

Wow, we don't have a test for this!?
Apparently it was lost when we migrated to compiler-rt :(
May I ask you to add one to compiler-rt/test/fuzzer?
(see fprofile-instr-generate.test in http://llvm.org/viewvc/llvm-project?view=revision&revision=310771)

This revision is now accepted and ready to land.Oct 5 2017, 3:03 PM
Dor1s updated this revision to Diff 117909.Oct 5 2017, 3:11 PM

Adding and updating fprofile-instr-generate.test that has been lost during
migration to compiler-rt.

kcc accepted this revision.Oct 5 2017, 3:14 PM

LGTM with a nit

test/fuzzer/fprofile-instr-generate.test
8 ↗(On Diff #117909)

add new line please

Dor1s updated this revision to Diff 117911.Oct 5 2017, 3:16 PM

Add newline at the end of the test file

Dor1s closed this revision.Oct 5 2017, 3:42 PM
Dor1s marked an inline comment as done.