Page MenuHomePhabricator
Differential D38561

[SparsePropagation] Move member definitions to header (NFC)
ClosedPublic
Actions

Authored by mssimpso on Oct 4 2017, 2:03 PM.

Details

Reviewers
• dberlin
davide
Commits
rG49ee81499605: [SparsePropagation] Move member definitions to header (NFC)
rL314996: [SparsePropagation] Move member definitions to header (NFC)
Summary

After rL314734, AbstractLatticeFunction and SparseSolver are class templates parameterized by a lattice value. In order to use the member functions, we need to move them into the header.

Diff Detail

Repository
rL LLVM

Event Timeline

mssimpso created this revision.Oct 4 2017, 2:03 PM
Herald added a subscriber: mgorny. · View Herald TranscriptOct 4 2017, 2:03 PM
mssimpso mentioned this in D37353: [SparsePropagation] Enable interprocedural analysis.Oct 4 2017, 2:04 PM
mssimpso added a child revision: D37353: [SparsePropagation] Enable interprocedural analysis.
• dberlin edited edge metadata.Oct 4 2017, 2:05 PM

LGTM

• dberlin accepted this revision.Oct 4 2017, 2:06 PM
This revision is now accepted and ready to land.Oct 4 2017, 2:06 PM
davide accepted this revision.Oct 4 2017, 2:12 PM

thanks

Closed by commit rL314996: [SparsePropagation] Move member definitions to header (NFC) (authored by mssimpso). · Explain WhyOct 5 2017, 11:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
llvm/
trunk/
include/
llvm/
Analysis/
336 lines
lib/
Analysis/
1 line
364 lines

Diff 117852

View Options

llvm/trunk/include/llvm/Analysis/SparsePropagation.h

Loading...
View Options

llvm/trunk/lib/Analysis/CMakeLists.txt

Loading...
View Options

llvm/trunk/lib/Analysis/SparsePropagation.cpp

Loading...