Page MenuHomePhabricator

[XRay][tools] Support arg1 logging entries in the basic logging mode
ClosedPublic

Authored by dberris on Oct 4 2017, 10:03 AM.

Details

Summary

The arg1 logging handler changed in compiler-rt to start writing a
different type for entries encountered when logging the first argument
of XRay-instrumented functions. This change allows the trace loader to
support reading these record types as well as prepare for when the
basic (naive) mode implementation starts writing down the argument
payloads.

Without this change, binaries with arg1 logging support enabled start
writing unreadable logs for any of the XRay tracing tools.

Diff Detail

Repository
rL LLVM

Event Timeline

dberris created this revision.Oct 4 2017, 10:03 AM
pelikan added inline comments.Oct 4 2017, 9:47 PM
lib/XRay/Trace.cpp
260–263 ↗(On Diff #117691)

These wraps are not necessary, it fits 80 characters well.

295–296 ↗(On Diff #117691)

These wraps are not necessary, it fits 80 characters well.

389–390 ↗(On Diff #117691)

These wraps are not necessary, it fits 80 characters well.

423–433 ↗(On Diff #117691)

These wraps are not necessary, it fits 80 characters well.

dberris updated this revision to Diff 117774.Oct 4 2017, 10:00 PM
dberris marked 4 inline comments as done.
  • fixup: undo intermediate clang-format atrefacts
pelikan accepted this revision.Oct 4 2017, 10:01 PM

LGTM now. Let's see what breaks :-)

This revision is now accepted and ready to land.Oct 4 2017, 10:01 PM
This revision was automatically updated to reflect the committed changes.