[Analyzer] Remove dead code from testing scripts

[george.karpenkov]

Summary

The SVN repository is no more, and the code for committing to the repository on results update now lives in the shell scripts together with reference results.

[dcoughlin]

This looks good to me. However, it is probably good form to email the cfe-dev list asking whether anyone is using the deleted functionality. If you don't hear anything in two weeks, delete it.

cfe/trunk/utils/analyzer/SATestBuild.py

for E in Extensions:
             P = os.path.join(SBOutputDir, F)
             RmCommand = "rm '%s'" % P
             check_call(RmCommand, shell=True)
 
     # Remove the log file. It leaks absolute path names.
     removeLogFile(SBOutputDir)
 
 
-def updateSVN(Mode, PMapFile):
-    """
-    svn delete or svn add (depending on `Mode`) all folders defined in the file
-    handler `PMapFile`.
-    Commit the result to SVN.
-    """
-    try:
-        for I in iterateOverProjects(PMapFile):
-            ProjName = I[0]
-            Path = os.path.join(ProjName, getSBOutputDirName(True))
-
-            if Mode == "delete":
-                Command = "svn delete '%s'" % (Path,)
-            else:
-                Command = "svn add '%s'" % (Path,)
-
-            if Verbose == 1:
-                print "  Executing: %s" % (Command,)
-            check_call(Command, shell=True)
-
-        if Mode == "delete":
-            CommitCommand = "svn commit -m \"[analyzer tests] Remove " \
-                            "reference results.\""
-        else:
-            CommitCommand = "svn commit -m \"[analyzer tests] Add new " \
-                            "reference results.\""
-        if Verbose == 1:
-            print "  Executing: %s" % (CommitCommand,)
-        check_call(CommitCommand, shell=True)
-    except:
-        print "Error: SVN update failed."
-        sys.exit(-1)
-
-
 def testProject(ID, ProjectBuildMode, IsReferenceBuild=False, Strictness=0):
     """
     Test a given project.
     :return TestsPassed: Whether tests have passed according
     to the :param Strictness: criteria.
     """
     print " \n\n--- Building project %s" % (ID,)
 
for I in iterateOverProjects(PMapFile):
             print "Error: Rows in the ProjectMapFile should have 2 entries."
             raise Exception()
         if (not ((I[1] == "0") | (I[1] == "1") | (I[1] == "2"))):
             print "Error: Second entry in the ProjectMapFile should be 0" \
                   " (single file), 1 (project), or 2(single file c++11)."
             raise Exception()
 
 
-def testAll(IsReferenceBuild=False, UpdateSVN=False, Strictness=0):
+def testAll(IsReferenceBuild=False, Strictness=0):
     TestsPassed = True
     with projectFileHandler() as PMapFile:
         validateProjectFile(PMapFile)
 
-        # When we are regenerating the reference results, we might need to
-        # update svn. Remove reference results from SVN.
-        if UpdateSVN:
-            assert(IsReferenceBuild)
-            updateSVN("delete", PMapFile)
-
         # Test the projects.
         for (ProjName, ProjBuildMode) in iterateOverProjects(PMapFile):
             TestsPassed &= testProject(
                 ProjName, int(ProjBuildMode), IsReferenceBuild, Strictness)
 
-        # Re-add reference results to SVN.
-        if UpdateSVN:
-            updateSVN("add", PMapFile)
-
 
 if __name__ == '__main__':
     # Parse command line arguments.
     Parser = argparse.ArgumentParser(
         description='Test the Clang Static Analyzer.')
     Parser.add_argument('--strictness', dest='strictness', type=int, default=0,
                         help='0 to fail on runtime errors, 1 to fail when the \
                              number of found bugs are different from the \
                              reference, 2 to fail on any difference from the \
                              reference. Default is 0.')
     Parser.add_argument('-r', dest='regenerate', action='store_true',
                         default=False, help='Regenerate reference output.')
-    Parser.add_argument('-rs', dest='update_reference', action='store_true',
-                        default=False,
-                        help='Regenerate reference output and update svn.')
     Args = Parser.parse_args()
 
     IsReference = False
-    UpdateSVN = False
     Strictness = Args.strictness
     if Args.regenerate:
         IsReference = True
-    elif Args.update_reference:
-        IsReference = True
-        UpdateSVN = True
 
-    TestsPassed = testAll(IsReference, UpdateSVN, Strictness)
+    TestsPassed = testAll(IsReference, Strictness)
     if not TestsPassed:
         sys.exit(-1)