This makes the output a little easier to read.
Details
Diff Detail
Event Timeline
test/DebugInfo/COFF/fp-stack.ll | ||
---|---|---|
15 | This one is a bit mysterious.. 128 / 0x80 is not in the RegisterId. Is the enum missing floating-point registers perhaps? |
test/DebugInfo/COFF/fp-stack.ll | ||
---|---|---|
15 | I guess it's FP0, from reading the comments in X86MCTargetDesc.cpp: // The x87 registers start at 128 and are numbered sequentially. unsigned FP0Start = 128; for (unsigned I = 0; I < 8; ++I) MRI->mapLLVMRegToCVReg(X86::FP0 + I, FP0Start + I); |
test/DebugInfo/COFF/fp-stack.ll | ||
---|---|---|
15 | These enumeration values are derived from the CV_HREG_e enumeration which is in cvconst.h https://github.com/Microsoft/microsoft-pdb/blob/master/include/cvconst.h In the followup, can you call them ST0, ST1, etc, to maintain naming consistency with the enumeration in cvconst? |
... we already had this? >_<