Page MenuHomePhabricator

Fix test by using -target instead of cc1 arguments (c-index-test goes through the driver)
Needs ReviewPublic

Authored by filcab on Sep 28 2017, 5:13 AM.

Details

Reviewers
akyrtzi
bkramer
Summary

If LLVM_DEFAULT_TARGET_TRIPLE is a non-darwin triple, the file might
fail. This might allow us to take out the FIXME and REQUIRES lines, but I'd
rather let the bots double-check that the test is ok first.

Event Timeline

filcab created this revision.Sep 28 2017, 5:13 AM
akyrtzi edited edge metadata.Oct 17 2017, 9:15 PM

FYI, I had added -target in this test in r296263 but it was still failing for some reason in some bots, that's why I then switched to triple via r296265.
I'm not sure if it's going work now or not for all bots, but it does, that is definitely better.