This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Fix typo: "in-tree" -> "in-source" (NFC)
ClosedPublic

Authored by modocache on Sep 27 2017, 7:07 AM.

Details

Summary

*In-source builds* of LLVM, in which a user invokes cmake from within the
LLVM source directory, or invokes cmake -B/path/to/source/dir/of/llvm,
are explicitly checked for and disallowed by LLVM's CMakeLists.txt.

*In-tree builds*, on the other hand, refer to when the source directories
of projects such as Clang are nested within the llvm/tools source
directory. These are not disallowed, and are in fact a common way of
building LLVM and Clang.

Revise the comment to match the logic underneath it: it checks for an
"in-source build", not an "in-tree build".

Event Timeline

modocache created this revision.Sep 27 2017, 7:07 AM
beanz accepted this revision.Sep 27 2017, 11:27 AM

LGTM!

This revision is now accepted and ready to land.Sep 27 2017, 11:27 AM
modocache closed this revision.Sep 27 2017, 2:39 PM

Great, thanks @beanz! I wanted to make sure I was understanding the terminology :)