Make LSan compliant with recovery mode when running on top of ASan

[rayslava]

Summary

Don't overwrite exit code in LSan when running on top of ASan in recovery mode to avoid breakage of users code due to found leaks.

[m.ostapenko]

lib/asan/asan_rtl.cc

463

please clang-format

test/asan/TestCases/recoverable-lsan.cc

10

Likewise.

[rayslava]

clang-format applied

[kcc]

test/asan/TestCases/recoverable-lsan.cc

4

Please format.
Why to you need to set detect_leaks (it's the default)?
Also, please add a line w/o halt_on_error flag to test the default behavior.

[rayslava]

Test header reformatted
Default behavior test added

lib/asan/asan_rtl.cc

   if (CAN_SANITIZE_LEAKS) {
     __lsan::InitCommonLsan();
     if (common_flags()->detect_leaks && common_flags()->leak_check_at_exit) {
-      Atexit(__lsan::DoLeakCheck);
+      if (flags()->halt_on_error)
+        Atexit(__lsan::DoLeakCheck);
+      else
+        Atexit(__lsan::DoRecoverableLeakCheckVoid);
     }
   }
 

lib/lsan/lsan_common.h

 // Functions called from the parent tool.
 void InitCommonLsan();
 void DoLeakCheck();
+void DoRecoverableLeakCheckVoid();
 void DisableCounterUnderflow();
 bool DisabledInThisThread();
 

lib/lsan/lsan_common.cc

   return have_leaks ? 1 : 0;
 }
 
+void DoRecoverableLeakCheckVoid() { DoRecoverableLeakCheck(); }
+
 static Suppression *GetSuppressionForAddr(uptr addr) {
   Suppression *s = nullptr;
 

 namespace __lsan {
 void InitCommonLsan() { }
 void DoLeakCheck() { }
+void DoRecoverableLeakCheckVoid() { }
 void DisableInThisThread() { }
 void EnableInThisThread() { }
 }

test/asan/TestCases/recoverable-lsan.cc

+// Ensure that output is the same but exit code depends on halt_on_error value
+// RUN: %clangxx_asan %s -o %t
+// RUN: %env_asan_opts="detect_leaks=1:halt_on_error=0" %run %t 2>&1 | FileCheck
+// %s RUN: %env_asan_opts="detect_leaks=1:halt_on_error=1" not %run %t 2>&1 |
+// FileCheck %s
+
+#include <stdlib.h>
+
+int f() {
+  volatile int *a = (int *)malloc(20);
+  a[0] = 1;
+  return a[0];
+}
+
+int main() {
+  f();
+  f();
+}
+
+// CHECK: LeakSanitizer: detected memory leaks
+// CHECK: SUMMARY: AddressSanitizer: 20 byte(s) leaked