Page MenuHomePhabricator

Make LSan compliant with recovery mode when running on top of ASan
ClosedPublic

Authored by rayslava on Sep 19 2017, 12:48 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

rayslava created this revision.Sep 19 2017, 12:48 AM
m.ostapenko added inline comments.
lib/asan/asan_rtl.cc
463 ↗(On Diff #115799)

please clang-format

test/asan/TestCases/recoverable-lsan.cc
9 ↗(On Diff #115799)

Likewise.

rayslava updated this revision to Diff 115811.Sep 19 2017, 2:36 AM

clang-format applied

kcc added inline comments.Sep 19 2017, 9:05 AM
test/asan/TestCases/recoverable-lsan.cc
4 ↗(On Diff #115811)

Please format.
Why to you need to set detect_leaks (it's the default)?
Also, please add a line w/o halt_on_error flag to test the default behavior.

rayslava updated this revision to Diff 115962.Sep 19 2017, 11:12 PM

Test header reformatted
Default behavior test added

kcc accepted this revision.Sep 20 2017, 4:08 PM
This revision is now accepted and ready to land.Sep 20 2017, 4:08 PM
This revision was automatically updated to reflect the committed changes.