This is an archive of the discontinued LLVM Phabricator instance.

Implement LWG2946: More ambiguity in `string` vs. `string_view`
AbandonedPublic

Authored by mclow.lists on Sep 18 2017, 1:43 PM.

Details

Reviewers
EricWF
Summary

See https://wg21.link/lwg2946 for details.

This issue has not yet been adopted by WG21, but I implemented it to make sure that there were no problems in the proposed resolution.

It turns out that there was. Making these changes lost the ability to construct a basic_string (w/o template parameters) from a string_view; i.e, the implicit deduction guides were no longer sufficient. So I added a couple of explicit deduction guides.

This will not be committed until after WG21 has approved this resolution.

Diff Detail

Event Timeline

mclow.lists created this revision.Sep 18 2017, 1:43 PM
mclow.lists updated this revision to Diff 137474.EditedMar 7 2018, 2:03 PM

Added the proposed resolution for https://wg21.link/lwg3075 as well, and some deduction guide tests for string_view

mclow.lists abandoned this revision.Feb 25 2019, 7:59 PM

This appears to have been applied in a slightly different form. Certainly the functionality is there. Closing.