Move to LoopUtils method that collects all children of a node inside a loop.
Details
Details
Diff Detail
Diff Detail
- Build Status
Buildable 10245 Build 10245: arc lint + arc unit
Event Timeline
Comment Actions
LGTM
I added a couple of stylistic issues that were present in the earlier function. I'll leave it up to you if you want to fix these.
lib/Transforms/Utils/LoopUtils.cpp | ||
---|---|---|
1124 | LLVM style is AddRegionToWorklist. | |
1133 | For integer loop counters, I've usually seem LLVM use i instead of I. | |
1135 | This can probably be for (DomTreeNode *Child : Worklist[i]), at which point the { braces won't be needed either. |
lib/Transforms/Utils/LoopUtils.cpp | ||
---|---|---|
1133 | That's true. I've seen both. Keeping I per the variable style guide. |
LLVM style is AddRegionToWorklist.