Fix bug 34608 by moving private header out of public header.WindowsManifestMerger.h should not include llvm/Config/config.h, since it is private. The include has been moved to the source instead.

[ecbeckmann]

Summary

The checksums had already been placed in the IR, this patch allows
MCCodeView to actually write it out to an MCStreamer.

Move private config.h header dependency out of public header file.

Addresses Bug 34608

[ecbeckmann]

Exclude checksums

[orivej]

This fixes the issue. Thank you!

[orivej]

llvm/lib/WindowsManifest/WindowsManifestMerger.cpp

16

Shouldn't the synonymous header be always the first include (to check that it is self-sufficient)?

[ecbeckmann]

Put synonymous header first.

[ecbeckmann]

llvm/lib/WindowsManifest/WindowsManifestMerger.cpp

16

right good point

llvm/include/llvm/WindowsManifest/WindowsManifestMerger.h

 // Ref:
 // https://msdn.microsoft.com/en-us/library/windows/desktop/aa374191(v=vs.85).aspx
 //
 //===---------------------------------------------------------------------===//
 
 #ifndef LLVM_INCLUDE_LLVM_SUPPORT_WINDOWS_MANIFEST_MERGER_H
 #define LLVM_INCLUDE_LLVM_SUPPORT_WINDOWS_MANIFEST_MERGER_H
 
-#include "llvm/Config/config.h"
 #include "llvm/Support/Error.h"
 
 namespace llvm {
 
 class MemoryBuffer;
 
 namespace windows_manifest {
 

llvm/lib/WindowsManifest/WindowsManifestMerger.cpp

 //===-- WindowsManifestMerger.cpp ------------------------------*- C++ -*-===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===---------------------------------------------------------------------===//
 //
 // This file implements the .manifest merger class.
 //
 //===---------------------------------------------------------------------===//
 
-#include "llvm/WindowsManifest/WindowsManifestMerger.h"
+#include "llvm/Config/config.h"
 #include "llvm/Support/MemoryBuffer.h"
+#include "llvm/WindowsManifest/WindowsManifestMerger.h"
 
 #include <map>
 
 #if LLVM_LIBXML2_ENABLED
 #include <libxml/xmlreader.h>
 #endif
 
 #define TO_XML_CHAR(X) reinterpret_cast<const unsigned char *>(X)