Page MenuHomePhabricator

Fix bug 34608 by moving private header out of public header.WindowsManifestMerger.h should not include llvm/Config/config.h, since it is private. The include has been moved to the source instead.
ClosedPublic

Authored by ecbeckmann on Sep 14 2017, 1:01 PM.

Details

Summary

The checksums had already been placed in the IR, this patch allows
MCCodeView to actually write it out to an MCStreamer.

Move private config.h header dependency out of public header file.

Addresses Bug 34608

Diff Detail

Repository
rL LLVM

Event Timeline

ecbeckmann created this revision.Sep 14 2017, 1:01 PM
ecbeckmann retitled this revision from Fix bug 34608 by moving private header out of public header. WindowsManifestMerger.h should not include llvm/Config/config.h, since it is private. The include has been moved to the source instead. to Fix bug 34608 by moving private header out of public header.WindowsManifestMerger.h should not include llvm/Config/config.h, since it is private. The include has been moved to the source instead..Sep 14 2017, 1:02 PM
ecbeckmann changed the visibility from "Public (No Login Required)" to "ecbeckmann (Eric Beckmann)".

Exclude checksums

ecbeckmann changed the visibility from "ecbeckmann (Eric Beckmann)" to "Public (No Login Required)".Sep 14 2017, 1:06 PM
ecbeckmann added reviewers: orivej, zturner.
orivej accepted this revision.Sep 14 2017, 1:25 PM

This fixes the issue. Thank you!

This revision is now accepted and ready to land.Sep 14 2017, 1:25 PM
orivej added inline comments.Sep 14 2017, 1:37 PM
llvm/lib/WindowsManifest/WindowsManifestMerger.cpp
16 ↗(On Diff #115271)

Shouldn't the synonymous header be always the first include (to check that it is self-sufficient)?

Put synonymous header first.

ecbeckmann marked an inline comment as done.Sep 14 2017, 4:00 PM
ecbeckmann added inline comments.
llvm/lib/WindowsManifest/WindowsManifestMerger.cpp
16 ↗(On Diff #115271)

right good point

ecbeckmann marked an inline comment as done.Sep 14 2017, 4:01 PM
This revision was automatically updated to reflect the committed changes.