This is an archive of the discontinued LLVM Phabricator instance.

[X86][Skylake][KNL] Updating code gen regression test to use the KNL and SKYLAKE prefixes. NFC,
ClosedPublic

Authored by gadi.haber on Sep 13 2017, 1:06 AM.

Details

Reviewers
delena
zvi
RKSimon
Summary

NFC.
Updating the code gen regression test bmi2-schedule.ll to use the KNL and SKYLAKE prefixes for the run commands that use the knl and Skylake mcpu options.
The fix is in preparation for a large patch of adding all SKL scheduling information.

Diff Detail

Repository
rL LLVM

Event Timeline

gadi.haber created this revision.Sep 13 2017, 1:06 AM
zvi edited edge metadata.Sep 13 2017, 1:21 AM

Can you please move the NFC to the Title:
[X86][Skylake][KNL] Updating code gen regression test to use the KNL and SKYLAKE prefixes. NFC.

test/CodeGen/X86/bmi2-schedule.ll
4

Can you please add a common --check-prefix to allow common CHECK:'s?

gadi.haber retitled this revision from [X86][Skylake][KNL] Updating code gen regression test to use the KNL and SKYLAKE prefixes to [X86][Skylake][KNL] Updating code gen regression test to use the KNL and SKYLAKE prefixes. NFC,.Sep 13 2017, 1:22 AM
RKSimon accepted this revision.Sep 13 2017, 1:32 AM
RKSimon added a reviewer: RKSimon.
RKSimon added a subscriber: RKSimon.

LGTM

test/CodeGen/X86/bmi2-schedule.ll
4

Given that these are per-target-cpu scheduler tests these are highly unlikely to be used, but won't do any harm. You could add a common prefix for HW/SKX/KNL as well if its important.

RKSimon accepted this revision.Sep 13 2017, 1:33 AM
This revision is now accepted and ready to land.Sep 13 2017, 1:33 AM

Updated diff to include the --check-prefix=COMMON flag in the run commands.

gadi.haber marked 2 inline comments as done.Sep 13 2017, 1:45 AM
RKSimon closed this revision.Sep 22 2017, 1:27 AM

This was committed at rL313138