NFC.
Updating the code gen regression test bmi2-schedule.ll to use the KNL and SKYLAKE prefixes for the run commands that use the knl and Skylake mcpu options.
The fix is in preparation for a large patch of adding all SKL scheduling information.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
Can you please move the NFC to the Title:
[X86][Skylake][KNL] Updating code gen regression test to use the KNL and SKYLAKE prefixes. NFC.
test/CodeGen/X86/bmi2-schedule.ll | ||
---|---|---|
4 | Can you please add a common --check-prefix to allow common CHECK:'s? |
Comment Actions
LGTM
test/CodeGen/X86/bmi2-schedule.ll | ||
---|---|---|
4 | Given that these are per-target-cpu scheduler tests these are highly unlikely to be used, but won't do any harm. You could add a common prefix for HW/SKX/KNL as well if its important. |
Can you please add a common --check-prefix to allow common CHECK:'s?