Page MenuHomePhabricator

[ASTMatchers] Allow isImplicit on all Decls.
ClosedPublic

Authored by joey on May 15 2014, 1:16 AM.

Details

Reviewers
klimek
djasper
pcc
Summary

isImplicit is currently for CXXConstructorDecls only, but there are other Decls that can be implicit.

I tried to write a small test, but if there is a better test let me know.

Diff Detail

Event Timeline

joey updated this revision to Diff 9413.May 15 2014, 1:16 AM
joey retitled this revision from to [ASTMatchers] Allow isImplicit on all Decls..
joey updated this object.
joey edited the test plan for this revision. (Show Details)
joey added a reviewer: djasper.
joey added a subscriber: Unknown Object (MLST).
pcc added a subscriber: pcc.May 15 2014, 11:05 AM
pcc added inline comments.
unittests/ASTMatchers/ASTMatchersTest.cpp
1776

This comment does not match what you are testing for.

joey updated this revision to Diff 9456.May 15 2014, 2:19 PM

Fixed the comment! Ok now?

pcc accepted this revision.May 15 2014, 3:10 PM
pcc added a reviewer: pcc.

LGTM

The only comment I would make is that in principle the compiler could change the assumption you are making in the test case about the implicit assignment operator. But (1) that observation is equally true of the other test cases (2) it would be easy to fix, say by taking a member pointer reference to the assignment operator.

This revision is now accepted and ready to land.May 15 2014, 3:10 PM
klimek accepted this revision.May 16 2014, 12:22 AM
klimek added a reviewer: klimek.

lg

joey added a comment.May 16 2014, 12:47 PM

Thanks guys, r209006!

joey closed this revision.May 16 2014, 12:48 PM