This is an archive of the discontinued LLVM Phabricator instance.

[GPUJIT] Improved temporary file handling.

Authored by PhilippSchaad on Sep 11 2017, 8:00 AM.

Diff Detail


Event Timeline

PhilippSchaad created this revision.Sep 11 2017, 8:00 AM
grosser accepted this revision.Sep 18 2017, 11:42 PM

Typo: "improve"

Otherwise, LGTM.

This revision is now accepted and ready to land.Sep 18 2017, 11:42 PM

Instead of POSIX, you should use the OS-independent abstractions for interfacing with the system in the llvm::sys and llvm::sys::fs namespaces.

This is a run-time library, we do not (yet) link with LLVM libraries.

My bad, didn't realize this was in GPUJIT and assumed it was related to D37429.

No worries. Thank you for reviewing!

Thank you both for the review!

This revision was automatically updated to reflect the committed changes.