[ELF] Fix flaky test

[jhenderson]

Summary

'@' is a valid character in file paths, but the linker script tokenizer treats it as a separate token. I have quoted the path to prevent this happening.

An alternative would have been to add '@' to the list of "unquoted tokens" in ScriptLexer.cpp, but I checked and ld.bfd has the same behaviour as the current LLD, so I have changed the test instead.

[ruiu]

I don't think I understand this patch.

echo "foo bar"

and

echo foo bar

print out the same string "foo bar" (without quotes).

Do you mean

echo "INCLUDE \"%t1.script\"" > %t1.script

?

(Also, where did your '@' character come from? This test doesn't contain '@'.)

[jhenderson]

Oops. Should have paid more attention!

The '@' comes from the %t. In our build system, there is sometimes an '@' in the workspace where this is run, causing the problem.

[ruiu]

LGTM

Please mention that this patch fixes the issue when your build path contains '@' character, instead of saying that this is flaky.

lld/trunk/test/ELF/linkerscript/include-cycle.s

 # REQUIRES: x86
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
 
-# RUN: echo INCLUDE %t1.script > %t1.script
+# RUN: echo "INCLUDE \"%t1.script\"" > %t1.script
 # RUN: not ld.lld %t.o %t1.script 2>&1 | FileCheck %s
 
-# RUN: echo INCLUDE %t2.script > %t1.script
-# RUN: echo INCLUDE %t1.script > %t2.script
+# RUN: echo "INCLUDE \"%t2.script\"" > %t1.script
+# RUN: echo "INCLUDE \"%t1.script\"" > %t2.script
 # RUN: not ld.lld %t.o %t1.script 2>&1 | FileCheck %s
 
 # CHECK: there is a cycle in linker script INCLUDEs
 
 .globl _start
 _start:
   ret