clang-format: [JS] wrap and indent `goog.setTestOnly` calls.

[mprobst]

Summary

While goog.setTestOnly usually appears in the imports section of a file, it is
not actually an import, and also usually doesn't take long parameters (nor
namespaces as a parameter, it's a description/message that should be wrapped).

This fixes a regression where a goog.setTestOnly call nested in a function was
not wrapped.

[djasper]

unittests/Format/FormatTestJS.cpp

570 ↗

(On Diff #114583)

How is this a regression?

I would just put this under the "// These should be wrapped normally." comment that's already there.

[mprobst]

• move test to different method

[mprobst]

unittests/Format/FormatTestJS.cpp

570 ↗

(On Diff #114583)

It's testing that goog.setTestOnly does not regress. That is, we don't have any code under test that special cases setTestOnly, so it's surprising to have a test case for it, but we should have one as we're confirming a previously incorrect behaviour. Your terminology might vary.

Done though, it does make sense to keep it together with the other case above.

cfe/trunk/lib/Format/TokenAnnotator.cpp

 private:
   bool isClosureImportStatement(const FormatToken &Tok) {
     // FIXME: Closure-library specific stuff should not be hard-coded but be
     // configurable.
     return Tok.TokenText == "goog" && Tok.Next && Tok.Next->is(tok::period) &&
            Tok.Next->Next && (Tok.Next->Next->TokenText == "module" ||
                               Tok.Next->Next->TokenText == "provide" ||
                               Tok.Next->Next->TokenText == "require" ||
-                              Tok.Next->Next->TokenText == "setTestOnly" ||
                               Tok.Next->Next->TokenText == "forwardDeclare") &&
            Tok.Next->Next->Next && Tok.Next->Next->Next->is(tok::l_paren);
   }
 
   void resetTokenMetadata(FormatToken *Token) {
     if (!Token)
       return;
 

cfe/trunk/unittests/Format/FormatTestJS.cpp

TEST_F(FormatTestJS, GoogModules) {
   verifyFormat("goog.module('this.is.really.absurdly.long');",
                getGoogleJSStyleWithColumns(40));
   verifyFormat("goog.require('this.is.really.absurdly.long');",
                getGoogleJSStyleWithColumns(40));
   verifyFormat("goog.provide('this.is.really.absurdly.long');",
                getGoogleJSStyleWithColumns(40));
   verifyFormat("var long = goog.require('this.is.really.absurdly.long');",
                getGoogleJSStyleWithColumns(40));
-  verifyFormat("goog.setTestOnly('this.is.really.absurdly.long');",
-               getGoogleJSStyleWithColumns(40));
   verifyFormat("goog.forwardDeclare('this.is.really.absurdly.long');",
                getGoogleJSStyleWithColumns(40));
 
   // These should be wrapped normally.
   verifyFormat(
       "var MyLongClassName =\n"
       "    goog.module.get('my.long.module.name.followedBy.MyLongClassName');");
+  verifyFormat("function a() {\n"
+               "  goog.setTestOnly();\n"
+               "}\n",
+               "function a() {\n"
+               "goog.setTestOnly();\n"
+               "}\n");
 }
 
 TEST_F(FormatTestJS, FormatsNamespaces) {
   verifyFormat("namespace Foo {\n"
                "  export let x = 1;\n"
                "}\n");
   verifyFormat("declare namespace Foo {\n"
                "  export let x: number;\n"