This is an archive of the discontinued LLVM Phabricator instance.

[X86][SKX][KNL] Updating several CodeGen tests to use the attr flag instead of mcpu flag
ClosedPublic

Authored by gadi.haber on Sep 11 2017, 12:22 AM.

Details

Reviewers
delena
RKSimon
zvi
Summary

NFC.
Updated 3 Codegen regression tests to use the -mattr flag instead of the -mcpu flags as follows:
Instead of -mcpu=skx use -mattr=+avx512f,+avx512bw,+avx512vl,+avx512dq
Instead of -mcpu=knl use -mattr=+avx512f

Diff Detail

Repository
rL LLVM

Event Timeline

gadi.haber created this revision.Sep 11 2017, 12:22 AM
delena added inline comments.Sep 11 2017, 12:39 AM
test/CodeGen/X86/pr32329.ll
4

Please add a comment about this test: According to https://bugs.llvm.org/show_bug.cgi?id=32329
it checks DAG ISEL failure on SKX target.

gadi.haber marked an inline comment as done.Sep 11 2017, 12:42 AM

Added the following comment to pr32329.ll:
"According to https://bugs.llvm.org/show_bug.cgi?id=32329 it checks DAG ISEL failure on SKX target"

generated new diff with all changes.

delena accepted this revision.Sep 11 2017, 2:50 AM

LGTM

This revision is now accepted and ready to land.Sep 11 2017, 2:50 AM
RKSimon closed this revision.Sep 22 2017, 1:35 AM
RKSimon edited edge metadata.

This was committed at rL312909