[sancov] coverage-report-server.py: ServerHandler(): open file as UTF8

[lebedev.ri]

Summary

This is nessesary in Python3. Everywhere else we assume that
encoding is UTF8. If we don't specify it here, the defaults
from the environment will be used, which may result in ASCII
decoder being used. And if the file is non-ASCII, then it
will crash:

  File "/usr/local/bin/coverage-report-server.py", line 168, in do_GET
    for line_no, line in enumerate(f, start=1)])
  File "/usr/local/bin/coverage-report-server.py", line 165, in <listcomp>
    ["<span class='{cls}'>{line}&nbsp;</span>".format(
  File "/usr/lib/python3.5/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 106: ordinal not in range(128)

Fixes https://bugs.llvm.org/show_bug.cgi?id=33548

Now, how would i add a testcase here?

[kcc]

can we just stick to python2?
I am not sure for how long this code will survive (I hope to migrate to clang's SourceBasedCodeCoverage) and don't want to spend time improving it.

[lebedev.ri]

In D37661#868351, @kcc wrote:

can we just stick to python2?
I am not sure for how long this code will survive (I hope to migrate to clang's SourceBasedCodeCoverage) and don't want to spend time improving it.

Right now that script hardcodes python3:

#!/usr/bin/env python3

IMHO python2 is dead, and really, really should not be used for anything new.

[kcc]

LGTM

I don't think we have any tests for this script :(

tools/sancov/coverage-report-server.py

def do_GET(self):
                 return
 
             self.send_response(200)
             self.send_header("Content-type", "text/html; charset=utf-8")
             self.end_headers()
 
             linemap = self.symcov_data.compute_linemap(filename)
 
-            with open(filepath, 'r') as f:
+            with open(filepath, 'r', encoding='utf8') as f:
                 content = "\n".join(
                         ["<span class='{cls}'>{line}&nbsp;</span>".format(
                             line=html.escape(line.rstrip()), 
                             cls=linemap.get(line_no, ""))
                             for line_no, line in enumerate(f, start=1)])
 
             response = string.Template(CONTENT_PAGE_TMPL).safe_substitute(
                 path=self.path[1:],