This is an archive of the discontinued LLVM Phabricator instance.

Differential D37649

[Driver] Support ubsan-minimal on Darwin
ClosedPublic

Authored by vsk on Sep 8 2017, 4:15 PM.

Details

Reviewers
eugenis
pcc
Commits
rGf56f77f5c829: [Driver] Support ubsan-minimal on Darwin
rC312958: [Driver] Support ubsan-minimal on Darwin
rL312958: [Driver] Support ubsan-minimal on Darwin
Summary

Make it possible to use the minimal ubsan runtime on Darwin.

Diff Detail

Event Timeline

vsk created this revision.Sep 8 2017, 4:15 PM
vsk mentioned this in D37646: [ubsan-minimal] Enable on Darwin.
eugenis accepted this revision.Sep 8 2017, 6:18 PM
This revision is now accepted and ready to land.Sep 8 2017, 6:18 PM
Closed by commit rL312958: [Driver] Support ubsan-minimal on Darwin (authored by vedantk). · Explain WhySep 11 2017, 2:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Driver/
ToolChains/
4 lines
test/
Driver/
7 lines

Diff 114458

lib/Driver/ToolChains/Darwin.cpp

Show First 20 Lines • Show All 992 Lines • ▼ Show 20 Lines
} }
const SanitizerArgs &Sanitize = getSanitizerArgs(); const SanitizerArgs &Sanitize = getSanitizerArgs();
if (Sanitize.needsAsanRt()) if (Sanitize.needsAsanRt())
AddLinkSanitizerLibArgs(Args, CmdArgs, "asan"); AddLinkSanitizerLibArgs(Args, CmdArgs, "asan");
if (Sanitize.needsLsanRt()) if (Sanitize.needsLsanRt())
AddLinkSanitizerLibArgs(Args, CmdArgs, "lsan"); AddLinkSanitizerLibArgs(Args, CmdArgs, "lsan");
if (Sanitize.needsUbsanRt()) if (Sanitize.needsUbsanRt())
AddLinkSanitizerLibArgs(Args, CmdArgs, "ubsan"); AddLinkSanitizerLibArgs(Args, CmdArgs,
Sanitize.requiresMinimalRuntime() ? "ubsan_minimal"
: "ubsan");
if (Sanitize.needsTsanRt()) if (Sanitize.needsTsanRt())
AddLinkSanitizerLibArgs(Args, CmdArgs, "tsan"); AddLinkSanitizerLibArgs(Args, CmdArgs, "tsan");
if (Sanitize.needsFuzzer() && !Args.hasArg(options::OPT_dynamiclib)) { if (Sanitize.needsFuzzer() && !Args.hasArg(options::OPT_dynamiclib)) {
AddLinkSanitizerLibArgs(Args, CmdArgs, "fuzzer", /*shared=*/false); AddLinkSanitizerLibArgs(Args, CmdArgs, "fuzzer", /*shared=*/false);
// Libfuzzer is written in C++ and requires libcxx. // Libfuzzer is written in C++ and requires libcxx.
AddCXXStdlibLibArgs(Args, CmdArgs); AddCXXStdlibLibArgs(Args, CmdArgs);
} }
▲ Show 20 Lines • Show All 986 Lines • Show Last 20 Lines

test/Driver/sanitizer-ld.c

Show First 20 Lines • Show All 248 Lines • ▼ Show 20 Lines
// RUN: %clang -fsanitize=undefined -fsanitize-minimal-runtime %s -### -o %t.o 2>&1 \ // RUN: %clang -fsanitize=undefined -fsanitize-minimal-runtime %s -### -o %t.o 2>&1 \
// RUN: -target i386-unknown-linux -fuse-ld=ld \ // RUN: -target i386-unknown-linux -fuse-ld=ld \
// RUN: --sysroot=%S/Inputs/basic_linux_tree \ // RUN: --sysroot=%S/Inputs/basic_linux_tree \
// RUN: | FileCheck --check-prefix=CHECK-UBSAN-MINIMAL-LINUX %s // RUN: | FileCheck --check-prefix=CHECK-UBSAN-MINIMAL-LINUX %s
// CHECK-UBSAN-MINIMAL-LINUX: "{{.*}}ld{{(.exe)?}}" // CHECK-UBSAN-MINIMAL-LINUX: "{{.*}}ld{{(.exe)?}}"
// CHECK-UBSAN-MINIMAL-LINUX: "-whole-archive" "{{.*}}libclang_rt.ubsan_minimal-i386.a" "-no-whole-archive" // CHECK-UBSAN-MINIMAL-LINUX: "-whole-archive" "{{.*}}libclang_rt.ubsan_minimal-i386.a" "-no-whole-archive"
// CHECK-UBSAN-MINIMAL-LINUX: "-lpthread" // CHECK-UBSAN-MINIMAL-LINUX: "-lpthread"
// RUN: %clang -fsanitize=undefined -fsanitize-minimal-runtime %s -### -o %t.o 2>&1 \
// RUN: -target x86_64-apple-darwin -fuse-ld=ld \
// RUN: --sysroot=%S/Inputs/basic_linux_tree \
// RUN: | FileCheck --check-prefix=CHECK-UBSAN-MINIMAL-DARWIN %s
// CHECK-UBSAN-MINIMAL-DARWIN: "{{.*}}ld{{(.exe)?}}"
// CHECK-UBSAN-MINIMAL-DARWIN: "{{.*}}libclang_rt.ubsan_minimal_osx_dynamic.dylib"
// RUN: %clang -fsanitize=address,undefined %s -### -o %t.o 2>&1 \ // RUN: %clang -fsanitize=address,undefined %s -### -o %t.o 2>&1 \
// RUN: -target i386-unknown-linux -fuse-ld=ld \ // RUN: -target i386-unknown-linux -fuse-ld=ld \
// RUN: --sysroot=%S/Inputs/basic_linux_tree \ // RUN: --sysroot=%S/Inputs/basic_linux_tree \
// RUN: | FileCheck --check-prefix=CHECK-ASAN-UBSAN-LINUX %s // RUN: | FileCheck --check-prefix=CHECK-ASAN-UBSAN-LINUX %s
// CHECK-ASAN-UBSAN-LINUX: "{{.*}}ld{{(.exe)?}}" // CHECK-ASAN-UBSAN-LINUX: "{{.*}}ld{{(.exe)?}}"
// CHECK-ASAN-UBSAN-LINUX: "-whole-archive" "{{.*}}libclang_rt.asan-i386.a" "-no-whole-archive" // CHECK-ASAN-UBSAN-LINUX: "-whole-archive" "{{.*}}libclang_rt.asan-i386.a" "-no-whole-archive"
// CHECK-ASAN-UBSAN-LINUX-NOT: libclang_rt.ubsan // CHECK-ASAN-UBSAN-LINUX-NOT: libclang_rt.ubsan
// CHECK-ASAN-UBSAN-LINUX-NOT: "-lstdc++" // CHECK-ASAN-UBSAN-LINUX-NOT: "-lstdc++"
▲ Show 20 Lines • Show All 296 Lines • Show Last 20 Lines