Page MenuHomePhabricator

[LLD][ELF] Rename variables and add comments to getISThunkSec [NFC]
ClosedPublic

Authored by peter.smith on Sep 8 2017, 9:02 AM.

Details

Summary

Some refactoring split out from D34691 that isn't strictly relating to it. It covers the renaming of some variables as Commands were moved to OutputSections the existing ones still imply commands. I've also tidied up the comments.

Diff Detail

Repository
rL LLVM

Event Timeline

peter.smith created this revision.Sep 8 2017, 9:02 AM
smeenai accepted this revision.Sep 8 2017, 9:48 AM
smeenai added inline comments.
ELF/Relocations.cpp
1028 ↗(On Diff #114372)

As far as I can see OS isn't used in this function anywhere. Can that parameter be dropped entirely? (I'm fine with that being done in a follow-up if it's possible.)

This revision is now accepted and ready to land.Sep 8 2017, 9:48 AM

I've removed the unused parameter and have searched for other locations where Cmd is used instead of OS.

Looks good to me still.

ruiu accepted this revision.Sep 11 2017, 4:36 PM

LGTM

This revision was automatically updated to reflect the committed changes.