This is an archive of the discontinued LLVM Phabricator instance.

Differential D37432

Fix a misleading phrase in the LangRef
ClosedPublic

Authored by sanjoy on Sep 3 2017, 6:18 PM.

Details

Reviewers
hfinkel
• dberlin
Commits
rG6d489490e651: Fix a misleading phrase in the LangRef
rL313170: Fix a misleading phrase in the LangRef

Diff Detail

Event Timeline

sanjoy created this revision.Sep 3 2017, 6:18 PM
Herald added a subscriber: mcrosier. · View Herald TranscriptSep 3 2017, 6:18 PM
hfinkel edited edge metadata.Sep 3 2017, 6:29 PM

I agree, this is better. Does this working make sense for vector GEPs?

sanjoy updated this revision to Diff 114501.Sep 9 2017, 8:18 PM
  • account for vector geps
Harbormaster completed remote builds in B10062: Diff 114501.Sep 9 2017, 8:18 PM
hfinkel accepted this revision.Sep 10 2017, 8:41 PM

LGTM

This revision is now accepted and ready to land.Sep 10 2017, 8:41 PM
Closed by commit rL313170: Fix a misleading phrase in the LangRef (authored by sanjoy). · Explain WhySep 13 2017, 11:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
docs/
2 lines

Diff 113715

docs/LangRef.rst

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 2,028 Lines • ▼ Show 20 Lines- An integer constant other than zero or a pointer value returned from
ranges allocated through mechanisms other than those provided by ranges allocated through mechanisms other than those provided by
LLVM. Such ranges shall not overlap with any ranges of addresses LLVM. Such ranges shall not overlap with any ranges of addresses
allocated by mechanisms provided by LLVM. allocated by mechanisms provided by LLVM.
A pointer value is *based* on another pointer value according to the A pointer value is *based* on another pointer value according to the
following rules: following rules:
- A pointer value formed from a ``getelementptr`` operation is *based* - A pointer value formed from a ``getelementptr`` operation is *based*
on the second value operand of the ``getelementptr``. on the pointer-typed operand of the ``getelementptr``.
- The result value of a ``bitcast`` is *based* on the operand of the - The result value of a ``bitcast`` is *based* on the operand of the
``bitcast``. ``bitcast``.
- A pointer value formed by an ``inttoptr`` is *based* on all pointer - A pointer value formed by an ``inttoptr`` is *based* on all pointer
values that contribute (directly or indirectly) to the computation of values that contribute (directly or indirectly) to the computation of
the pointer's value. the pointer's value.
- The "*based* on" relationship is transitive. - The "*based* on" relationship is transitive.
Note that this definition of *"based"* is intentionally similar to the Note that this definition of *"based"* is intentionally similar to the
▲ Show 20 Lines • Show All 12,346 Lines • Show Last 20 Lines