Fix debuginfo-tests with GDB on Linux

[rnk]

Summary

Split asan.c into asan.c and asan-blocks.c, which will be
darwin-specific. I suspect we could make it pass on Linux by adding
cmake to build BlocksRuntime from compiler-rt, but I'm not shaving that
yak yet.

asan.c and safestack.c: GDB and LLDB appear to print aggregates
differently today. Print individual elements instead of the entire
aggregate.

dbg-arg.c: GDB doesn't appear to print leading zeros when printing
pointers.

stack-var.c: Add the optnone attribute so that LLVM won't optimize away
this no-op function call. This should be a cross-platform failure
observable on Mac, so this is surprising.

[aprantl]

Looks good except for the one inline comment.

debuginfo-tests/asan-blocks.c

3 ↗

(On Diff #113436)

can you have more than one REQUIRES line or do you need to comma-separate the values?

[aprantl]

LGTM with outstanding issues addressed.

[rnk]

Thanks!

debuginfo-tests/asan-blocks.c

3 ↗

(On Diff #113436)

Looks like I can do that.

BTW, it's probably worth shaving this yak. ASan and blocks are the two main users of complex dwarf expressions, so we really do want to get test coverage of them everwhere. I'll look into it.

[aprantl]

Yes, looks like it is still running, it!
http://green.lab.llvm.org/green/job/clang-stage1-configure-RA_check/35057/consoleFull

$ pbpaste | grep debuginfo-test
PASS: Clang :: debuginfo-tests/forward-declare-class.cpp (11768 of 39401)
PASS: Clang :: debuginfo-tests/nested-struct.cpp (11769 of 39401)
XFAIL: Clang :: debuginfo-tests/static-member-2.cpp (11823 of 39401)
PASS: Clang :: debuginfo-tests/aggregate-indirect-arg.cpp (11826 of 39401)
PASS: Clang :: debuginfo-tests/sret.cpp (11827 of 39401)
PASS: Clang :: debuginfo-tests/vla.c (11828 of 39401)
PASS: Clang :: debuginfo-tests/dbg-arg.c (11829 of 39401)
PASS: Clang :: debuginfo-tests/ctor.cpp (11830 of 39401)
PASS: Clang :: debuginfo-tests/stack-var.c (11831 of 39401)
PASS: Clang :: debuginfo-tests/safestack.c (11833 of 39401)
PASS: Clang :: debuginfo-tests/asan.c (11846 of 39401)
PASS: Clang :: debuginfo-tests/asan-blocks.c (11848 of 39401)
PASS: Clang :: debuginfo-tests/static-member.cpp (11879 of 39401)
PASS: Clang :: debuginfo-tests/block_var.m (12252 of 39401)
PASS: Clang :: debuginfo-tests/foreach.m (12330 of 39401)
PASS: Clang :: debuginfo-tests/blocks.m (12844 of 39401)

debuginfo-tests/trunk/asan-blocks.c

+// RUN: %clang -fblocks %target_itanium_abi_host_triple -arch x86_64 %s -o %t.out -g -fsanitize=address
+// RUN: %test_debuginfo %s %t.out
+// FIXME: Remove system-darwin when we build BlocksRuntime everywhere.
+// REQUIRES: not_asan, system-darwin
+//           Zorg configures the ASAN stage2 bots to not build the asan
+//           compiler-rt. Only run this test on non-asanified configurations.
+void b();
+struct S {
+  int a[8];
+};
+
+int f(struct S s, unsigned i) {
+  // DEBUGGER: break 17
+  // DEBUGGER: r
+  // DEBUGGER: p s
+  // CHECK: a = ([0] = 0, [1] = 1, [2] = 2, [3] = 3, [4] = 4, [5] = 5, [6] = 6, [7] = 7)
+  return s.a[i];
+}
+
+int main(int argc, const char **argv) {
+  struct S s = {{0, 1, 2, 3, 4, 5, 6, 7}};
+  if (f(s, 4) == 4) {
+    // DEBUGGER: break 27
+    // DEBUGGER: c
+    // DEBUGGER: p s
+    // CHECK: a = ([0] = 0, [1] = 1, [2] = 2, [3] = 3, [4] = 4, [5] = 5, [6] = 6, [7] = 7)
+    b();
+  }
+  return 0;
+}
+
+void c() {}
+
+void b() {
+  // DEBUGGER: break 40
+  // DEBUGGER: c
+  // DEBUGGER: p x
+  // CHECK: 42
+  __block int x = 42;
+  c();
+}

debuginfo-tests/trunk/asan.c

-// RUN: %clang %target_itanium_abi_host_triple -arch x86_64 %s -o %t.out -g -fsanitize=address
+// RUN: %clang -fblocks %target_itanium_abi_host_triple -arch x86_64 %s -o %t.out -g -fsanitize=address
 // RUN: %test_debuginfo %s %t.out
 // REQUIRES: not_asan
 //           Zorg configures the ASAN stage2 bots to not build the asan
 //           compiler-rt. Only run this test on non-asanified configurations.
-void b();
+//
+
 struct S {
   int a[8];
 };
 
 int f(struct S s, unsigned i) {
-  // DEBUGGER: break 16
-  // DEBUGGER: r
-  // DEBUGGER: p s
-  // CHECK: a = ([0] = 0, [1] = 1, [2] = 2, [3] = 3, [4] = 4, [5] = 5, [6] = 6, [7] = 7)
+  // DEBUGGER: break 14
   return s.a[i];
 }
 
 int main(int argc, const char **argv) {
   struct S s = {{0, 1, 2, 3, 4, 5, 6, 7}};
-  if (f(s, 4) == 4) {
-    // DEBUGGER: break 26
-    // DEBUGGER: c
-    // DEBUGGER: p s
-    // CHECK: a = ([0] = 0, [1] = 1, [2] = 2, [3] = 3, [4] = 4, [5] = 5, [6] = 6, [7] = 7)
-    b();
-  }
+  if (f(s, 4) == 4)
+    return f(s, 0);
   return 0;
 }
 
-void c() {}
-
-void b() {
-  // DEBUGGER: break 39
-  // DEBUGGER: c
-  // DEBUGGER: p x
-  // CHECK: 42
-  __block int x = 42;
-  c();
-}
+// DEBUGGER: r
+// DEBUGGER: p s
+// CHECK: a =
+// DEBUGGER: p s.a[0]
+// CHECK: = 0
+// DEBUGGER: p s.a[1]
+// CHECK: = 1
+// DEBUGGER: p s.a[7]

debuginfo-tests/trunk/dbg-arg.c

 // This test case checks debug info during register moves for an argument.
-// RUN: %clang %target_itanium_abi_host_triple -arch x86_64 -mllvm -fast-isel=false  %s -c -o %t.o -g
-// RUN: %clang %target_itanium_abi_host_triple -arch x86_64 %t.o -o %t.out
+// RUN: %clang %target_itanium_abi_host_triple -m64 -mllvm -fast-isel=false  %s -c -o %t.o -g
+// RUN: %clang %target_itanium_abi_host_triple -m64 %t.o -o %t.out
 // RUN: %test_debuginfo %s %t.out
 //
 // DEBUGGER: break 26
 // DEBUGGER: r
 // DEBUGGER: print mutex
-// CHECK:  ={{.*}} 0x0
+// CHECK:  ={{.* 0x[0-9A-Fa-f]+}}
 //
 // Radar 8412415
 
 struct _mtx
 {
   long unsigned int ptr;
   int waiters;
   struct {

debuginfo-tests/trunk/safestack.c

 
 int f(struct S s, unsigned i) {
   // DEBUGGER: break 24
   return s.a[i];
 }
 
 // DEBUGGER: r
 // DEBUGGER: p s
-// CHECK: a = ([0] = 0, [1] = 1, [2] = 2, [3] = 3, [4] = 4, [5] = 5, [6] = 6, [7] = 7)
+// CHECK: a =
+// DEBUGGER: p s.a[0]
+// CHECK: = 0
+// DEBUGGER: p s.a[1]
+// CHECK: = 1
+// DEBUGGER: p s.a[7]
+// CHECK: = 7
 // DEBUGGER: c
 // DEBUGGER: p s
-// CHECK: a = ([0] = 0, [1] = 1, [2] = 2, [3] = 3, [4] = 4, [5] = 5, [6] = 6, [7] = 7)
+// CHECK: a =
+// DEBUGGER: p s.a[0]
+// CHECK: = 0
+// DEBUGGER: p s.a[1]
+// CHECK: = 1
+// DEBUGGER: p s.a[7]
 // DEBUGGER: c
 // DEBUGGER: p s
-// CHECK: a = ([0] = 0, [1] = 1, [2] = 2, [3] = 3, [4] = 4, [5] = 5, [6] = 6, [7] = 7)
+// CHECK: a =
+// DEBUGGER: p s.a[0]
+// CHECK: = 0
+// DEBUGGER: p s.a[1]
+// CHECK: = 1
+// DEBUGGER: p s.a[7]

debuginfo-tests/trunk/stack-var.c

 // RUN: %clang %target_itanium_abi_host_triple %s -O -o %t.out -g
 // RUN: %test_debuginfo %s %t.out
 
-void __attribute__((noinline)) bar(int *test) {}
+void __attribute__((noinline, optnone)) bar(int *test) {}
 int main() {
   int test;
   test = 23;
   // DEBUGGER: break 12
   // DEBUGGER: r
   // DEBUGGER: p test
-  // CHECK: 23
+  // CHECK: = 23
   bar(&test);
   // DEBUGGER: break 17
   // DEBUGGER: c
   // DEBUGGER: p test
-  // CHECK: 23
+  // CHECK: = 23
   return test;
 }