Page MenuHomePhabricator

[Bash-autocomplete] Refactor autocomplete code into own function
ClosedPublic

Authored by yamaguchi on Aug 28 2017, 9:51 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

yamaguchi created this revision.Aug 28 2017, 9:51 PM
teemperor added inline comments.Aug 28 2017, 10:59 PM
clang/lib/Driver/Driver.cpp
1160 ↗(On Diff #113018)

I think a more generic interface would be void Driver::handleAutocompletions(StringRef PassedFlags) const { as we don't really require that the user of this function actually has an Arg with a value before calling this function.

yamaguchi marked an inline comment as done.

Update diff. I agree that this is more generic.

This revision is now accepted and ready to land.Aug 29 2017, 7:10 AM
This revision was automatically updated to reflect the committed changes.