This is an archive of the discontinued LLVM Phabricator instance.

[llvm-pdbutil] Print detailed S_UDT stats
AcceptedPublic

Authored by zturner on Aug 28 2017, 2:46 PM.

Details

Reviewers
rnk
inglorion
Summary

This breaks down all S_UDT records in a PDB file by the leaf kind it points to and prints counts and size totals for each one.

Additionally, it breaks down the records by namespace. In the future I intend to add object file support so we can get this kind of output with individual object files as well, whish should help greatly in figuring out PDB size issues.

Diff Detail

Event Timeline

zturner created this revision.Aug 28 2017, 2:46 PM
inglorion accepted this revision.Aug 28 2017, 3:39 PM

Mostly lgtm; please take a look at the couple of inline comments before landing.

llvm/tools/llvm-pdbutil/DumpOutputStyle.cpp
624

Underscores are good, too, right?

665

Consider changing the wording here so that we don't print "Error" but return success. Maybe "No S_UDT stats; globals stream not present"?

This revision is now accepted and ready to land.Aug 28 2017, 3:39 PM