This is an archive of the discontinued LLVM Phabricator instance.

Differential D37228

Proper dependency check for clang in compiler_rt
ClosedPublic

Authored by george.karpenkov on Aug 28 2017, 12:37 PM.

Details

Reviewers
kubamracek
Commits
rG16a05f2dfe00: Proper dependency check for clang in compiler_rt.
rCRT311911: Proper dependency check for clang in compiler_rt.
rL311911: Proper dependency check for clang in compiler_rt.
Summary

A working alternative to https://reviews.llvm.org/D37126:

  • Not having a dependency does not work in standalone build, as Clang does not exist.
  • if (TARGET clang) check is useless, as it is order-dependent, and Clang may not be registered yet.

Diff Detail

Event Timeline

george.karpenkov created this revision.Aug 28 2017, 12:37 PM
Herald added a subscriber: mgorny. · View Herald TranscriptAug 28 2017, 12:37 PM
kubamracek accepted this revision.Aug 28 2017, 12:38 PM
This revision is now accepted and ready to land.Aug 28 2017, 12:38 PM
Closed by commit rL311911: Proper dependency check for clang in compiler_rt. (authored by george.karpenkov). · Explain WhyAug 28 2017, 12:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cmake/
Modules/
2 lines

Diff 112936

cmake/Modules/CompilerRTCompile.cmake

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines set(CMD
" echo" " echo"
" false" " false"
"fi" "fi"
) )
add_custom_target(CompilerRTUnitTestCheckCxx add_custom_target(CompilerRTUnitTestCheckCxx
COMMAND bash -c "${CMD}" COMMAND bash -c "${CMD}"
COMMENT "Checking that just-built clang can find C++ headers..." COMMENT "Checking that just-built clang can find C++ headers..."
VERBATIM) VERBATIM)
if (TARGET clang) if (NOT COMPILER_RT_STANDALONE_BUILD)
ADD_DEPENDENCIES(CompilerRTUnitTestCheckCxx clang) ADD_DEPENDENCIES(CompilerRTUnitTestCheckCxx clang)
endif() endif()
endif() endif()
endmacro() endmacro()