This is an archive of the discontinued LLVM Phabricator instance.

Add test to cover accurate-sample-profile.
ClosedPublic

Authored by danielcdh on Aug 23 2017, 4:00 PM.

Details

Summary

This patch adds test to cover the logic guarded by "accurate-sample-profile" flag.

Event Timeline

danielcdh created this revision.Aug 23 2017, 4:00 PM
davidxl edited edge metadata.Aug 23 2017, 4:07 PM

What happens if caller is hot, and the callee (missing profile) is unconditionally called by the caller? Will it still be treated as cold?

What happens if caller is hot, and the callee (missing profile) is unconditionally called by the caller? Will it still be treated as cold?

Yes, it will be treated as cold. In practice, if the caller is hot and callsite is missing profile, it is most likely it is cold.

davidxl accepted this revision.Aug 23 2017, 4:17 PM

lgtm

This revision is now accepted and ready to land.Aug 23 2017, 4:17 PM
danielcdh closed this revision.Aug 23 2017, 4:20 PM