This one doesn't contain any other modifications except those done to Scop::foldSizeConstantsToRight()
A lot better, some comments.
Why do you introduce a new variable. Just use:
isl::union_set Accesses = getAccesses.range();
Same here, this can be written as:
isl::space Space = Array->getSpace();
No need for "(" after the "!"
This works? This should read:
int Dims = Elements.dim(isl::dim::set);
This should read:
isl::set DimOnly = Elements.project_out(isl::dim::set, 0, i);
Add isl:: prefix.
Also, do you need two local_space ?
Does this compile?
No copy is needed here. Just write:
isl::basic_set ZeroSet = DimHull;
Does this work? It should probably read:
No need for a return.
Drop the empty line.
Also, for future reference, note that an old review can be updated: There is an update diff option to the right hand side at the top of the web page. That way, we won't have multiple revisions like D37061 and D36843. This reduces the number of places someone needs to look to see the total change :). Thanks!
thank you for your update. This looks already a lot better, but it seems the patch above does not yet pass 'make check-polly'. Could you possibly address the remaining bugs. Most of them should be pretty straightforward.
Why does what I suggested above not work? It seems you drop the _range() call? Does this pass "make check-polly"?
I just applied your patch using "arc patch D37061", but it seems to not yet compile. Did you test it locally?
This line does not compile for me. I get the following error:
/home/grosser/Projects/polly/git/tools/polly/lib/Analysis/ScopInfo.cpp:3405:45: error: expected '(' for function-style cast or type construction isl::union_set Accessed = isl::union_set union_map::range(getAccesses.release());