Page MenuHomePhabricator

[Polly] Second Updated translating the function Scop::foldSizeConstantsToRight() to isl C++
Needs RevisionPublic

Authored by Siddharth on Aug 17 2017, 12:32 PM.

Details

Reviewers
bollu
grosser
Summary

Updated patch removing comments and other unimportant code and comparison is with actual polly code .So creating a new revision. Will abandon all others.

Diff Detail

Event Timeline

Siddharth created this revision.Aug 17 2017, 12:32 PM
Siddharth edited the summary of this revision. (Show Details)Aug 17 2017, 12:36 PM
Siddharth added a reviewer: grosser.
grosser edited edge metadata.Aug 17 2017, 12:39 PM

This patch still looks broken.

annanay25 added inline comments.
lib/Analysis/ScopInfo.cpp
1226

[Style] Why are we using C-style syntax?

1288

[Doubt] When would this not be true?

3546

Thanks for porting!

3620

[Nit] Needed?

5244

[Serious] Why has this been deleted? It is called in buildConditionSets.

Could you add a test case to prove?

grosser requested changes to this revision.Aug 22 2017, 1:19 PM

Hey Siddharth,

please try to upload a clean patch without other noise. I mark this as requesting changes to be notified when this has been updated.

This revision now requires changes to proceed.Aug 22 2017, 1:19 PM