Page MenuHomePhabricator

[llvm-rc] Add ICON and HTML parsing ability [2/8]
ClosedPublic

Authored by mnbvmar on Aug 18 2017, 1:18 PM.

Details

Summary

This extends the current llvm-rc parser by ICON and HTML resources.

Diff Detail

Repository
rL LLVM

Event Timeline

mnbvmar created this revision.Aug 18 2017, 1:18 PM
mnbvmar created this object with visibility "mnbvmar (Marek Sokołowski)".
mnbvmar created this object with edit policy "mnbvmar (Marek Sokołowski)".
mnbvmar changed the visibility from "mnbvmar (Marek Sokołowski)" to "Public (No Login Required)".
mnbvmar changed the edit policy from "mnbvmar (Marek Sokołowski)" to "All Users".
ecbeckmann edited edge metadata.Aug 18 2017, 2:12 PM

this looks fine to me.

mnbvmar updated this revision to Diff 112440.Aug 23 2017, 2:10 PM
mnbvmar retitled this revision from [llvm-rc] Add ICON and HTML parsing ability. to [llvm-rc] Add ICON and HTML parsing ability [2/8].

Replace files with pipes.

Looks fine to me.

rnk accepted this revision.Aug 23 2017, 5:16 PM

lgtm

This revision is now accepted and ready to land.Aug 23 2017, 5:16 PM
This revision was automatically updated to reflect the committed changes.