This is an archive of the discontinued LLVM Phabricator instance.

[X86] Allow xacquire/xrelease prefixes
ClosedPublic

Authored by coby on Aug 17 2017, 12:51 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

coby created this revision.Aug 17 2017, 12:51 PM
RKSimon added inline comments.Aug 18 2017, 4:14 AM
lib/Target/X86/AsmParser/X86AsmParser.cpp
2471 ↗(On Diff #111546)

Why did you move data32 to the top instead of leaving next to data16?

coby updated this revision to Diff 111729.Aug 18 2017, 1:26 PM

Why did you move data32 to the top instead of leaving next to data16?

no particular reason. back in place

RKSimon edited edge metadata.Aug 18 2017, 1:36 PM

Please can you add tests for the intel-syntax acquire/release as well?

coby updated this revision to Diff 111876.Aug 20 2017, 5:10 AM

@RKSimon : Please can you add tests for the intel-syntax acquire/release as well?

Added.

This revision is now accepted and ready to land.Aug 20 2017, 11:07 PM
This revision was automatically updated to reflect the committed changes.