This is an archive of the discontinued LLVM Phabricator instance.

When built with ASan, __cxa_throw calls __asan_handle_no_return
ClosedPublic

Authored by mcgrathr on Aug 10 2017, 5:11 PM.

Details

Summary

The ASan runtime on many systems intercepts cxa_throw just so it
can call
asan_handle_no_return first. Some newer systems such as
Fuchsia don't use interceptors on standard library functions at all,
but instead use sanitizer-instrumented versions of the standard
libraries. When libc++abi is built with ASan, cxa_throw can just
call
asan_handle_no_return itself so no interceptor is required.

Diff Detail

Repository
rL LLVM

Event Timeline

mcgrathr created this revision.Aug 10 2017, 5:11 PM
phosek edited edge metadata.Aug 14 2017, 4:39 PM

@EricWF does this look fine to you? I'm happy with this change and I'd like to land it if possible.

phosek accepted this revision.Aug 16 2017, 11:59 AM

LGTM

This revision is now accepted and ready to land.Aug 16 2017, 11:59 AM
This revision was automatically updated to reflect the committed changes.