While we do not support -mshared / -mno-shared properly, show warning and ignore -mlong-calls option in case of implicitly or explicitly provided -mabicalls option.
The patch depends on D36550.
Paths
| Differential D36551
[mips] Show warning in case of mixing -mlong-calls and -mabicalls options ClosedPublic Authored by atanasyan on Aug 9 2017, 2:09 PM.
Details Summary While we do not support -mshared / -mno-shared properly, show warning and ignore -mlong-calls option in case of implicitly or explicitly provided -mabicalls option. The patch depends on D36550.
Diff Detail
Event Timeline
Comment Actions LGTM.
This revision is now accepted and ready to land.Aug 10 2017, 6:18 AM
Closed by commit rL310614: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options (authored by atanasyan). · Explain WhyAug 10 2017, 8:43 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 110478 include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Arch/Mips.cpp
test/Driver/mips-features.c
test/Driver/mips-longcalls-warning.c
|
"as it is not currently supported with "
I think is better, as we currently don't support mixing the options but could do in the future.