GC code contains following logic uncovered by tests:
(nothing fails if I remove these 2 lines)
for (StringRef S : Config->Undefined) MarkSymbol(Symtab->find(S));
As far I can tell we never had test for that before,
patch fixes it.
Differential D36519
[ELF] - Add a test for --gc-sections --undefined=foo combination. grimar on Aug 9 2017, 6:52 AM. Authored by
Details GC code contains following logic uncovered by tests: for (StringRef S : Config->Undefined) MarkSymbol(Symtab->find(S)); As far I can tell we never had test for that before,
Diff Detail
Event TimelineComment Actions There is no issue. We just missing the test. I tried to remove following lines: for (StringRef S : Config->Undefined) MarkSymbol(Symtab->find(S)); from elf::markLive() and all our tests passed. Comment Actions LGTM
|