This is an archive of the discontinued LLVM Phabricator instance.

compute isPreemtible only once
ClosedPublic

Authored by rafael on Aug 8 2017, 5:59 PM.

Details

Reviewers
ruiu
smeenai
Summary

This is probably a small optimization, but the main motivation is having a way of fixing pr34053 that doesn't require a hash lookup in isPreempitible.

Diff Detail

Event Timeline

rafael created this revision.Aug 8 2017, 5:59 PM
ruiu added inline comments.Aug 8 2017, 10:01 PM
ELF/Symbols.cpp
141

Is it possible to define this function as a non-member static function? if it is doable, it is preferable, because it makes clear that this function does not depend on private members.

rafael updated this revision to Diff 110497.Aug 9 2017, 4:32 PM

Make computeIsPreemptible a static function.

ruiu accepted this revision.Aug 10 2017, 6:03 AM

LGTM

This revision is now accepted and ready to land.Aug 10 2017, 6:03 AM
smeenai closed this revision.Aug 10 2017, 12:42 PM
smeenai edited edge metadata.

SVN r310602.