This is an archive of the discontinued LLVM Phabricator instance.

[NewGVN] Use a cast instead of a dyn_cast.
ClosedPublic

Authored by mcrosier on Aug 8 2017, 11:12 AM.

Reviewers

• dberlin
davide

Commits

thank you!

This revision is now accepted and ready to land.Aug 8 2017, 11:15 AM

This revision was automatically updated to reflect the committed changes.

LGTM

Path

Size

lib/

Transforms/

Scalar/

4 lines

Show First 20 Lines • Show All 1,705 Lines • ▼ Show 20 Lines	if (II && EI->getNumIndices() == 1 && *EI->idx_begin() == 0) {
Opcode, EI->getType(), II->getArgOperand(0), II->getArgOperand(1));		Opcode, EI->getType(), II->getArgOperand(0), II->getArgOperand(1));
}		}
}		}
}		}

return createAggregateValueExpression(I);		return createAggregateValueExpression(I);
}		}
const Expression NewGVN::performSymbolicCmpEvaluation(Instruction I) const {		const Expression NewGVN::performSymbolicCmpEvaluation(Instruction I) const {
auto *CI = dyn_cast<CmpInst>(I);		assert(isa<CmpInst>(I) && "Expected a cmp instruction.");

		auto *CI = cast<CmpInst>(I);
// See if our operands are equal to those of a previous predicate, and if so,		// See if our operands are equal to those of a previous predicate, and if so,
// if it implies true or false.		// if it implies true or false.
auto Op0 = lookupOperandLeader(CI->getOperand(0));		auto Op0 = lookupOperandLeader(CI->getOperand(0));
auto Op1 = lookupOperandLeader(CI->getOperand(1));		auto Op1 = lookupOperandLeader(CI->getOperand(1));
auto OurPredicate = CI->getPredicate();		auto OurPredicate = CI->getPredicate();
if (shouldSwapOperands(Op0, Op1)) {		if (shouldSwapOperands(Op0, Op1)) {
std::swap(Op0, Op1);		std::swap(Op0, Op1);
OurPredicate = CI->getSwappedPredicate();		OurPredicate = CI->getSwappedPredicate();
▲ Show 20 Lines • Show All 2,237 Lines • Show Last 20 Lines