This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment pragmas
ClosedPublic

Authored by krasimir on Aug 5 2017, 8:36 AM.

Event Timeline

krasimir created this revision.Aug 5 2017, 8:36 AM
mprobst added inline comments.Aug 7 2017, 2:13 PM
lib/Format/BreakableToken.cpp
688

Can you add a comment on what this is doing? It's non obvious. Make sure to document both intention (why) and implementation (how).

688

I don't understand why we're trimming Content.back() here, and Lines.back() below.

690

Whitespaces seems like a bad variable name, isn't this rather the index of trimmed whitespace in the last line?

krasimir updated this revision to Diff 110156.Aug 8 2017, 2:41 AM
  • Simplify getSplitAfterLastLine
krasimir marked 3 inline comments as done.Aug 8 2017, 2:41 AM
krasimir updated this revision to Diff 110157.Aug 8 2017, 2:42 AM
  • Remove debugging
mprobst accepted this revision.Aug 8 2017, 7:41 AM
This revision is now accepted and ready to land.Aug 8 2017, 7:41 AM
This revision was automatically updated to reflect the committed changes.