Previously we would use these instructions if sse was disabled and fastmath was enabled.
As mentioned in D28335, this is a bad idea.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
Just a minor question on the test changes. Otherwise, this LGTM.
| test/CodeGen/X86/sincos-opt.ll | ||
|---|---|---|
| 124 ↗ | (On Diff #109839) | Was moving the check for 'ret' here intentional? |
| test/CodeGen/X86/sincos-opt.ll | ||
|---|---|---|
| 124 ↗ | (On Diff #109839) | I think all I did was copy the GNU_SINCOS check lines from above and changed them to say GNU_SINCOS_FASTMATH. I hadn't noticed the difference in the ret. |
| test/CodeGen/X86/sincos-opt.ll | ||
|---|---|---|
| 124 ↗ | (On Diff #109839) | Do you want me to add it back or is it ok like this? |
Comment Actions
Adding Zvi as an FYI, but I think this is fine to land.
| test/CodeGen/X86/sincos-opt.ll | ||
|---|---|---|
| 124 ↗ | (On Diff #109839) | As far as I'm concerned it's okay either way. |