This is an archive of the discontinued LLVM Phabricator instance.

[Polly][PM] Make the new-pm passes behave more like the legacy passes
ClosedPublic

Authored by philip.pfaffe on Aug 4 2017, 1:32 AM.

Details

Summary

Testing the new-pm passes becomes much easier once they behave more like the
old passes in terms of the order in which Scops are processed and printed. This
requires three changes:

  • ScopInfo: Use an ordered map to store scops
  • ScopInfo: Iterate and print Scops in reverse order to match legacy PM behaviour
  • ScopDetection: print function name in ScopAnalysisPrinter

Event Timeline

philip.pfaffe created this revision.Aug 4 2017, 1:32 AM
grosser accepted this revision.Aug 4 2017, 4:16 AM

LGTM.

We may want to discuss if a better path ordering is possible, but I would prefer to have (close-to) full test coverage before improving this.

lib/Analysis/ScopInfo.cpp
5293

Maybe add a comment why you are doing this.

This revision is now accepted and ready to land.Aug 4 2017, 4:16 AM
This revision was automatically updated to reflect the committed changes.