This is an archive of the discontinued LLVM Phabricator instance.

Differential D36297

Disable libFuzzer tests on Windows
ClosedPublic

Authored by george.karpenkov on Aug 3 2017, 5:20 PM.

Details

Reviewers
kcc
Commits
rG5bd050368093: Disable libFuzzer tests on Windows
rL310009: Disable libFuzzer tests on Windows
Summary

See https://reviews.llvm.org/D36205 for justification and discussion.

Diff Detail

Event Timeline

george.karpenkov created this revision.Aug 3 2017, 5:20 PM
Herald added a subscriber: mgorny. · View Herald TranscriptAug 3 2017, 5:20 PM
kcc accepted this revision.Aug 3 2017, 5:25 PM

LGTM

This revision is now accepted and ready to land.Aug 3 2017, 5:25 PM
Closed by commit rL310009: Disable libFuzzer tests on Windows (authored by george.karpenkov). · Explain WhyAug 3 2017, 5:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Fuzzer/
12 lines

Diff 109662

lib/Fuzzer/CMakeLists.txt

Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Linesif ( LLVM_USE_SANITIZE_COVERAGE OR CMAKE_SYSTEM_NAME MATCHES "Darwin|Linux" )
target_link_libraries(LLVMFuzzerNoMain ${LLVM_PTHREAD_LIB}) target_link_libraries(LLVMFuzzerNoMain ${LLVM_PTHREAD_LIB})
add_library(LLVMFuzzer STATIC add_library(LLVMFuzzer STATIC
FuzzerMain.cpp FuzzerMain.cpp
$<TARGET_OBJECTS:LLVMFuzzerNoMainObjects> $<TARGET_OBJECTS:LLVMFuzzerNoMainObjects>
) )
target_link_libraries(LLVMFuzzer ${LLVM_PTHREAD_LIB}) target_link_libraries(LLVMFuzzer ${LLVM_PTHREAD_LIB})
endif() endif()
if (MSVC)
# Until bots are reconfigured, check-fuzzer on Windows is a no-OP.
add_custom_target(check-fuzzer)
add_custom_command(TARGET check-fuzzer
COMMAND cmake -E echo "check-fuzzer is disalbed on Windows")
else()
if( LLVM_USE_SANITIZE_COVERAGE AND LLVM_INCLUDE_TESTS ) if( LLVM_USE_SANITIZE_COVERAGE AND LLVM_INCLUDE_TESTS )
add_subdirectory(test) add_subdirectory(test)
endif() endif()
endif()